refactor(filesource): replace repetitive #[cfg()] usages with cfg_if!{}#3832
Closed
rami3l wants to merge 1 commit into
Closed
refactor(filesource): replace repetitive #[cfg()] usages with cfg_if!{}#3832rami3l wants to merge 1 commit into
#[cfg()] usages with cfg_if!{}#3832rami3l wants to merge 1 commit into
Conversation
Contributor
|
A simpler way of doing this would be to just move all the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It occurred to me right after #3811 that we actually have
cfg_ifin our imports, so using it more should provide better ergonomics and prevent issues like #3811 happen again (i.e. "I forgot to add#[cfg()]to some constructs but not others").I plan to adjust #3803 to use
cfg_if!{}inrustup-init.rsas well, where we also tend to use quite a lot of conditionally compiled constructs.